Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to disable task update size tracking #24562

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

NikhilCollooru
Copy link
Contributor

@NikhilCollooru NikhilCollooru commented Feb 14, 2025

Description

Add support to disable task update size tracking

Motivation and Context

During some profiling, when the cluster is running hot, there is contention when trying to update the taskupdate size stats, as it is a synchronized method. So this PR is to have the ability to disable this task update size tracking.

Impact

None

Test Plan

Existing tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@NikhilCollooru NikhilCollooru requested a review from a team as a code owner February 14, 2025 01:02
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Feb 14, 2025
Copy link
Contributor

@shangm2 shangm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arhimondr arhimondr merged commit 6f09c57 into prestodb:master Feb 14, 2025
53 checks passed
@NikhilCollooru NikhilCollooru deleted the disTaskUpdateSizeTracking branch February 14, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants