-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[velox] refactor: Rename velox casting utilities to camelCase convention #26687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juwentus1234
wants to merge
1
commit into
prestodb:master
Choose a base branch
from
juwentus1234:export-D87806227
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookincubator/velox#15614 X-link: facebookincubator/nimble#333 Renamed three function templates in velox's casting utilities to follow the camelCase naming convention: - `checked_pointer_cast` → `checkedPointerCast` - `static_unique_pointer_cast` → `staticUniquePointerCast` - `is_instance_of` → `isInstanceOf` This change affects the function definitions in `/data/users/ericjjj/fbsource/fbcode/velox/common/Casts.h` and all call sites within the velox codebase and related projects that use velox namespaced functions. Files updated: - Function definitions in `velox/common/Casts.h` - Velox core files: `core/PlanNode.cpp`, `exec/Exchange.cpp`, `exec/Task.cpp`, `common/memory/MemoryPool.cpp`, `tool/trace/TopNRowNumberReplayer.cpp` - Test file: `velox/common/testutil/tests/CastsTest.cpp` - updated all test cases - DataInfra/Sequence files that use `facebook::velox::` namespace prefix (8 files) This refactoring improves consistency with velox's naming conventions while maintaining backward compatibility with external codebases that use their own implementations. Differential Revision: D87806227
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors Velox casting utilities to use camelCase function names and updates all affected call sites, keeping behavior the same while aligning with naming conventions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/velox#15614
X-link: facebookincubator/nimble#333
Renamed three function templates in velox's casting utilities to follow the camelCase naming convention:
checked_pointer_cast→checkedPointerCaststatic_unique_pointer_cast→staticUniquePointerCastis_instance_of→isInstanceOfThis change affects the function definitions in
/data/users/ericjjj/fbsource/fbcode/velox/common/Casts.hand all call sites within the velox codebase and related projects that use velox namespaced functions.Files updated:
velox/common/Casts.hcore/PlanNode.cpp,exec/Exchange.cpp,exec/Task.cpp,common/memory/MemoryPool.cpp,tool/trace/TopNRowNumberReplayer.cppvelox/common/testutil/tests/CastsTest.cpp- updated all test casesfacebook::velox::namespace prefix (8 files)This refactoring improves consistency with velox's naming conventions while maintaining backward compatibility with external codebases that use their own implementations.
Differential Revision: D87806227