Skip to content

Conversation

@juwentus1234
Copy link
Contributor

Summary:
X-link: facebookincubator/velox#15614

X-link: facebookincubator/nimble#333

Renamed three function templates in velox's casting utilities to follow the camelCase naming convention:

  • checked_pointer_castcheckedPointerCast
  • static_unique_pointer_caststaticUniquePointerCast
  • is_instance_ofisInstanceOf

This change affects the function definitions in /data/users/ericjjj/fbsource/fbcode/velox/common/Casts.h and all call sites within the velox codebase and related projects that use velox namespaced functions.

Files updated:

  • Function definitions in velox/common/Casts.h
  • Velox core files: core/PlanNode.cpp, exec/Exchange.cpp, exec/Task.cpp, common/memory/MemoryPool.cpp, tool/trace/TopNRowNumberReplayer.cpp
  • Test file: velox/common/testutil/tests/CastsTest.cpp - updated all test cases
  • DataInfra/Sequence files that use facebook::velox:: namespace prefix (8 files)

This refactoring improves consistency with velox's naming conventions while maintaining backward compatibility with external codebases that use their own implementations.

Differential Revision: D87806227

Summary:
X-link: facebookincubator/velox#15614

X-link: facebookincubator/nimble#333

Renamed three function templates in velox's casting utilities to follow the camelCase naming convention:
- `checked_pointer_cast` → `checkedPointerCast`
- `static_unique_pointer_cast` → `staticUniquePointerCast`
- `is_instance_of` → `isInstanceOf`

This change affects the function definitions in `/data/users/ericjjj/fbsource/fbcode/velox/common/Casts.h` and all call sites within the velox codebase and related projects that use velox namespaced functions.

Files updated:
- Function definitions in `velox/common/Casts.h`
- Velox core files: `core/PlanNode.cpp`, `exec/Exchange.cpp`, `exec/Task.cpp`, `common/memory/MemoryPool.cpp`, `tool/trace/TopNRowNumberReplayer.cpp`
- Test file: `velox/common/testutil/tests/CastsTest.cpp` - updated all test cases
- DataInfra/Sequence files that use `facebook::velox::` namespace prefix (8 files)

This refactoring improves consistency with velox's naming conventions while maintaining backward compatibility with external codebases that use their own implementations.

Differential Revision: D87806227
@juwentus1234 juwentus1234 requested review from a team as code owners November 24, 2025 22:41
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors Velox casting utilities to use camelCase function names and updates all affected call sites, keeping behavior the same while aligning with naming conventions.

File-Level Changes

Change Details Files
Rename Velox casting utility templates to camelCase and propagate changes to all call sites.
  • Update casting utility template names in the core Velox casting header to camelCase equivalents while preserving signatures and behavior
  • Adjust all internal Velox call sites to use the new camelCase casting helpers instead of the old snake_case versions
  • Update Presto native execution shuffle operators to use the new checkedPointerCast helper when downcasting stream and batch pointers
  • Refresh tests and external/related project code that reference the casting utilities to the new names to ensure compilation and coverage remain intact
velox/common/Casts.h
velox/core/PlanNode.cpp
velox/exec/Exchange.cpp
velox/exec/Task.cpp
velox/common/memory/MemoryPool.cpp
velox/tool/trace/TopNRowNumberReplayer.cpp
velox/common/testutil/tests/CastsTest.cpp
presto-native-execution/presto_cpp/main/operators/LocalShuffle.cpp
presto-native-execution/presto_cpp/main/operators/ShuffleRead.cpp
DataInfra/Sequence/... (8 files)

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants