feat(optimizer): Support predicate stitching in MaterializedViewRewrite #26728
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @tdcmeehan, your pull request is larger than the review limit of 150000 diff characters
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Nice work on the documentation! A few nits and suggestions, nothing major.
| In this example: | ||
|
|
||
| * ``orders.order_date`` and ``customers.reg_date`` are equivalent due to the equality join condition | ||
| * Even though ``reg_date`` is not in the MV's SELECT list, staleness can be tracked through the equivalence to ``order_date`` |
There was a problem hiding this comment.
| * Even though ``reg_date`` is not in the MV's SELECT list, staleness can be tracked through the equivalence to ``order_date`` | |
| * Even though ``reg_date`` is not in the SELECT list, staleness can be tracked through the equivalence to ``order_date`` |
The all caps MV was jarring. Suggest removing it as not needed because of context supporting the meaning, or maybe "the materialized view's SELECT list".
|
|
||
| **How Passthrough Mapping Works** | ||
|
|
||
| 1. **Equivalence Extraction**: During MV creation, Presto analyzes JOIN conditions to identify |
There was a problem hiding this comment.
Same comment as above about MV. Suggest deleting, or spelling it out.
| * Join must be an INNER JOIN (not LEFT, RIGHT, or FULL OUTER) | ||
| * Equality must be direct (``col1 = col2``), not through expressions like ``col1 = col2 + 1`` | ||
| * Both columns must be partition columns in their respective tables | ||
| * At least one column in the equivalence class must be in the MV's output |
There was a problem hiding this comment.
Same comment as above about MV. Suggest deleting, or spelling it out.
|
|
||
| - All refreshes recompute the entire result set | ||
| - REFRESH does not provide snapshot isolation across multiple base tables | ||
| - All refreshes recompute the entire result set (incremental refresh not yet supported) |
There was a problem hiding this comment.
| - All refreshes recompute the entire result set (incremental refresh not yet supported) | |
| - All refreshes recompute the entire result set (incremental refresh not supported) |
"yet" is an implied promise that should be avoided in documentation.
I thought about suggesting deleting the entire parenthetical "(incremental refresh not yet supported)" as it's arguably implied in "All refreshes recompute the entire result set", but I also find value in the explicit declaration of "incremental refresh not supported" so I could go either way on it and be fine with it staying.
| 3. Partition constraints are built that identify exactly which data is stale | ||
|
|
||
| See the connector-specific documentation for details on how staleness is tracked. | ||
| For Iceberg tables, see :doc:`/connector/iceberg` (Materialized Views section). |
There was a problem hiding this comment.
| For Iceberg tables, see :doc:`/connector/iceberg` (Materialized Views section). | |
| For Iceberg tables, see :ref:`connector/iceberg:materialized views`. |
Tested improved link in local doc build.
tdcmeehan
force-pushed
the
mv-iceberg-disjuncts
branch
4 times, most recently
from
05e8c4a to
ab3ceea
Compare
tdcmeehan
force-pushed
the
mv-iceberg-disjuncts
branch
2 times, most recently
from
e7c3d3a to
2cc1534
Compare
tdcmeehan
force-pushed
the
mv-iceberg-disjuncts
branch
from
2cc1534 to
24d1537
Compare
3 participants
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: