Add RFC-0018 for Java connector federation in C++ workers #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
ShahimSharafudeen and
nishithakbhaskaran
and removed request for
a team
tdcmeehan
force-pushed
the
conn
branch
9 times, most recently
from
eced569 to
826a238
Compare
BryanCutler
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
LGTM, thanks @tdcmeehan. I mostly just had some questions about auth with the flight server
infvg
reviewed
Sep 9, 2025
tdcmeehan
force-pushed
the
conn
branch
3 times, most recently
from
bdfb6b2 to
79aed22
Compare
tdcmeehan
force-pushed
the
conn
branch
2 times, most recently
from
a4ddced to
7196f6d
Compare
pdabre12
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
Thanks @tdcmeehan , LTGM.
Should we add some documentation on how to load up the new ArrowFederationConnector?
BryanCutler
approved these changes
Sep 17, 2025
RFC-0013-java-connector-federaton.md
Outdated
|
|
||
| #### Split Scheduling Phase | ||
| 1. Coordinator's single-node connector (e.g., JDBC, MongoDB) creates its connector-specific split | ||
| 2. Split is scheduled to C++ worker as `ArrowFederationSplit` containing serialized split bytes |
There was a problem hiding this comment.
Just to clarify, the coordinator will send a connector-specific split to the C++ worker, but it will be handled by the ArrowFederation protocol where it will be read as bytes only.
There was a problem hiding this comment.
Thanks, made that a bit more clear.
|
FYI |
7 tasks
tdcmeehan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.