Skip to content

Reduce spacing between consecutive <dt> elements #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FloEdelmann
Copy link

What are you trying to accomplish?

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dt:

multiple <dt> elements in a row indicate several terms that are all defined by the immediate next <dd> element

Example usage on GitHub: https://github.com/tummychow/git-absorb/blob/master/Documentation/git-absorb.adoc

Currently, those are separated by a 1rem margin, making them look like separate definitions (without a description):

grafik

What approach did you choose and why?

Reduce the spacing between consecutive <dt> elements to zero:

grafik

This is a similar approach to consecutive <li> elements and makes definition lists more readable.

What should reviewers focus on?

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@FloEdelmann FloEdelmann requested a review from a team as a code owner March 10, 2025 14:48
@FloEdelmann FloEdelmann requested a review from emilybrick March 10, 2025 14:48
Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: 47431de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant