-
Notifications
You must be signed in to change notification settings - Fork 638
feat(ActionList): Combine Item and LinkItem into unified Item component #6956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5dddb63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
…/github.com/primer/react into liuliu/actionlist-combine-item-and-linkitem
Testing completed, closing this PR and will build a more polished implementation |
Closes #5916
Combines
ActionList.Item
andActionList.LinkItem
into a single unifiedActionList.Item
component that automatically switches between button and link behavior based on props. Developers no longer need to choose betweenItem
andLinkItem
Changes
ActionList.Item
now supports both button and link functionality. Automatically uses link behavior whenhref
,to
, or link-related props are provided. ExistingActionList.Item
usage continues to work unchangedItem
toBaseItem
Item
component routes toBaseItem
orLinkItem
based on propsLinkItem
to useBaseItem
internallyActionList.LinkItem
toActionList.Item
Usage Examples
Rollout strategy
Testing & Reviewing
Testing in
github-ui
: https://github.com/github/github-ui/pull/4026