-
Notifications
You must be signed in to change notification settings - Fork 638
styled-react: Add ThemeProvider and BaseStyles #6958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0f30134 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4296 |
Increased wait time for tooltip delay to ensure stable screenshots.
🟢 ci completed with status |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
primer_react_use_styled_react_theming
createGlobalStyle
instead of css modulesWe are in the process of removing styled-components from
@primer/react
and moving styled-components based styling to@primer/styled-react
. This includesThemeProvider
,BaseStyles
anduseTheme
It's important that ThemeProvider and a component or utility (like useTheme) that depends on the theme uses the same instance of Context from styled-components.
To roll this change out safely, we are using a feature flag that can serve as a kill switch to go back to using theme components from
@primer/react
like today.To do this, we are
@primer/react
theme components (like ThemeProvider) from@primer/styled-react
@primer/styled-react
The plan is to roll this change out slowly over a week and then removing the feature flag
Rollout strategy
Testing & Reviewing
Merge checklist