fix: add graphql to peerDependencies #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollo-link depends on graphql as peer dep, so this package also has graphql as a (transitive) peer dep that needs to be listed
arcanis
added a commit
to yarnpkg/berry
that referenced
this pull request
Apr 1, 2020
* plugin-compat: extension for http-link-dataloader See prisma-labs/http-link-dataloader#22 * Adds versions Co-authored-by: Maël Nison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package depends on
apollo-link, which listsgraphqlas a peer dependency.Because of this, graphql also is a (transitive) peer dependency of
http-link-dataloaderitself and needs to be listed as such.Otherwise users see warnings, potential errors and if they're using a package manager that actually enforces package boundaries (like Yarn 2) it can't be used to begin with unless you fix the peerDependencies manually. (that's what happened to me)