-
Notifications
You must be signed in to change notification settings - Fork 72
ci: Add workflow to lint/test skore-remote-project
#1598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
66f65d3
to
846f612
Compare
path: skore/coverage/ | ||
|
||
backend: | ||
skore: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to change this required job in the GH settings before merging, when the PR is validated.
c144308
to
6f9616d
Compare
6f9616d
to
7e58c64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally fine with this, just questions/nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to factor out some of this logic?
Not sure that trying to factor this is worth it. It will probably diverge in the futur...
Some changes to prepare for the arrival of the new package `skore-remote-project`: - Rename the `skore` workflow from `backend` to `skore`, - Factorize `pr-display-backend-coverage` to be usable by both `skore` and `skore-remote-project`, - Add the structure of the package `skore-remote-project`, - Add the `skore-remote-project` workflow.
Some changes to prepare for the arrival of the new package
skore-remote-project
:skore
workflow frombackend
toskore
,pr-display-backend-coverage
to be usable by bothskore
andskore-remote-project
,skore-remote-project
,skore-remote-project
workflow.