Skip to content

ci: Add workflow to lint/test skore-remote-project #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

thomass-dev
Copy link
Collaborator

@thomass-dev thomass-dev commented Apr 25, 2025

Some changes to prepare for the arrival of the new package skore-remote-project:

  • Rename the skore workflow from backend to skore,
  • Factorize pr-display-backend-coverage to be usable by both skore and skore-remote-project,
  • Add the structure of the package skore-remote-project,
  • Add the skore-remote-project workflow.

@thomass-dev thomass-dev force-pushed the ci-skore-remote-project branch 3 times, most recently from 66f65d3 to 846f612 Compare April 25, 2025 16:19
path: skore/coverage/

backend:
skore:
Copy link
Collaborator Author

@thomass-dev thomass-dev Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change this required job in the GH settings before merging, when the PR is validated.

@thomass-dev thomass-dev force-pushed the ci-skore-remote-project branch 8 times, most recently from c144308 to 6f9616d Compare April 28, 2025 08:14
@thomass-dev thomass-dev marked this pull request as ready for review April 28, 2025 08:22
@thomass-dev thomass-dev force-pushed the ci-skore-remote-project branch from 6f9616d to 7e58c64 Compare April 28, 2025 08:28
Copy link
Contributor

@rouk1 rouk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

Copy link
Contributor

@auguste-probabl auguste-probabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine with this, just questions/nitpicks

Copy link
Contributor

@rouk1 rouk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to factor out some of this logic?

Not sure that trying to factor this is worth it. It will probably diverge in the futur...

@thomass-dev thomass-dev merged commit c548583 into main Apr 28, 2025
42 checks passed
@thomass-dev thomass-dev deleted the ci-skore-remote-project branch April 28, 2025 08:57
Muhammad-Rebaal pushed a commit to Muhammad-Rebaal/skore that referenced this pull request May 5, 2025
Some changes to prepare for the arrival of the new package
`skore-remote-project`:

- Rename the `skore` workflow from `backend` to `skore`,
- Factorize `pr-display-backend-coverage` to be usable by both `skore`
and `skore-remote-project`,
- Add the structure of the package `skore-remote-project`,
- Add the `skore-remote-project` workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants