chore: Replace cross_validation with CrossValidationReport in warnings
#1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schefflera-Arboricola
changed the title
cross_validation with CrossValidationReport in warnings
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
auguste-probabl
changed the title
cross_validation with CrossValidationReport in warningscross_validation with CrossValidationReport in warnings
|
Please don't merge this yet, we're testing the new merge queue |
Muhammad-Rebaal
pushed a commit
to Muhammad-Rebaal/skore
that referenced
this pull request
May 5, 2025
…nings (probabl-ai#1601) the `cross_validation` function doesn't exist anymore. It was replace in PR probabl-ai#847 with the `CrossValidationReport` class. Please let me know if this change LGTY-- or should I've replaced "skore's `cross_validation` function." with something in sklearn (e.g. - this page: https://scikit-learn.org/stable/modules/cross_validation.html#cross-validation)? Thank you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
cross_validationfunction doesn't exist anymore. It was replace in PR #847 with theCrossValidationReportclass. Please let me know if this change LGTY-- or should I've replaced "skore'scross_validationfunction." with something in sklearn (e.g. - this page: https://scikit-learn.org/stable/modules/cross_validation.html#cross-validation)?Thank you :)