-
Notifications
You must be signed in to change notification settings - Fork 1
Convert Devenv to Nix flake #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
893c54c
to
a454f6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ok afaict, but I'm not a Nix or python expert.
It looks like the Github commit-lint action is broken, though. It says it can't find pnpm. (If it helps, I generally have good luck debugging GH Actions locally with the act tool.)
Yeah I'm having a look into that, it's weird because the step before also uses |
The devshell can now be entered either using Direnv (https://direnv.net) or by manually running `nix develop`.
a454f6d
to
648edc2
Compare
…eing too far down PYTHONPATH
This reverts commit 052468e.
Looks good afaict. I noticed the .envrc is running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tho see my note about watching all nix files recursively.
The Devenv dotfiles can be removed as Devenv is no longer used at all. However well pointed out as I'd forgotten to remove the old unused flake stub in the The |
Change .envrc to use Bash file globbing rather than the find sub-shell invocation.
@Schaechtle @srounce I just noticed, the docs weren't updated to match. |
The |
/var/...
Supercedes #194 & #195, incorporating the fixes they provide.