Fix #162. #164
Open
Fix #162. #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to probcomp/bayeslite#489 this doesn't really help with the issue of dealing with all-NaN columns when a population is created (as values may be nullified when the population is created, resulting in all-NaN columns that originally had a few values). This might still be a useful function though, so I'll leave the PR here. |
fsaad
reviewed
Oct 30, 2016
| """ | ||
| df = table_to_df(bdb, tablename) | ||
| df.dropna(axis=1, how='all', inplace=True) | ||
| drop_table_query = 'DROP TABLE IF EXISTS %s' %( |
There was a problem hiding this comment.
Is the IF EXISTS clause required here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a quick way to fix tables to comply with probcomp/bayeslite@d1fbdac