Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run pre-commit on all files, convert to ruff #29

Merged
merged 5 commits into from
Mar 11, 2025
Merged

Conversation

sritchie
Copy link
Contributor

@sritchie sritchie commented Mar 6, 2025

This PR:

  • runs the pre-commit hooks on all files
  • converts to the Ruff formatter + the pre-commit config currently used by genlm-{backend, grammar, control}

@sritchie sritchie changed the title run pre-commit on all files run pre-commit on all files, convert to ruff Mar 6, 2025
@sritchie sritchie requested a review from benlebrun March 6, 2025 12:54
@benlebrun benlebrun requested review from gabegrand and removed request for benlebrun March 6, 2025 14:52
Copy link
Collaborator

@gabegrand gabegrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sritchie sritchie merged commit 632acb6 into main Mar 11, 2025
2 checks passed
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 66.00%. Comparing base (3aacd9b) to head (c46679e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hfppl/llms.py 50.00% 18 Missing ⚠️
hfppl/chunks.py 50.00% 1 Missing ⚠️
hfppl/distributions/lmcontext.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   66.05%   66.00%   -0.05%     
==========================================
  Files          17       17              
  Lines         710      709       -1     
==========================================
- Hits          469      468       -1     
  Misses        241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants