pr05 Typescript Migration #11: Migrate server/routes folder #3643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairep94
changed the title
…exports, no-verify
…t-exports, no-verify
khanniie
previously approved these changes
Sep 21, 2025
server/routes/user.routes.ts
Outdated
| import isAuthenticated from '../utils/isAuthenticated'; | ||
|
|
||
| const router = new Router(); | ||
| export const router = Router(); |
There was a problem hiding this comment.
is this export needed if you export default on it later?
| passport.authenticate( | ||
| service, | ||
| { failureRedirect: '/login' }, | ||
| (err: any, user: any) => { |
There was a problem hiding this comment.
small nit but are there better types for these other than any? something from passport's types?
There was a problem hiding this comment.
I tried to find an error and user type from the passport @types, but I think they declare User as {}, and use err: any
I think when I migrate the User model, I can import it and use it, but error might just stay as any
|
@khanniie I updated to address some feedback, so might need a re-review when you're ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr05 Typescript Migration 11: Migrate the server/routes folder
Should be reviewed after #3636
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123