migrating Preferences and Messages to stand-alone version #1130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1104
Changes
Preferences
to:app:utils
module making it independent ofapp
module by also moving the functionalities that depends onapp
toAppPreferences
classMessages
class to be able to use it (for example in debugging) in different areas of ProcessingUtils
into:app:utils
, because why keeping it inapp
it doesn't need any functionalities from there, and also can be used in:app:utils
without the need to depend onapp
getSettingsFolder()
method for each platform from:app
to:app:utils
, without duplication the code i madeapp.Platform
class to depend onSettingsResolver
in:app:utils
to get the correct location for each platformdefaults.txt
now by using JAR resource system instead ofPlatform.getContentFile()
(which is also marked as deprecated in the codebase encouraging to migrate to JAR RS)Todo
Tests
I tried to compile and run, as for now preferences are loaded and saved correctly
but for some reason some languages aren't displayed properly like: arabic , chinese, but languages like: english, japanese properly displayed.
I will look into it, but any help or suggestion of why that happens is very much appreciated