added support in requests.Session #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uriyay thanks for the contribution, however this change as you can see breaks tests on the existing functionality. We should potentially introduce checking if session is the instance of Session. If it is not then we perform the default requests.post. If session is the instance of Session then we can produce a session.post. Note please include tests to cover these scenarios. |
…n. added tests for testing client.execute() with a given session object
xkludge
reviewed
Mar 22, 2024
| **kwargs: Any, | ||
| ): | ||
| """Make synchronous request to graphQL server.""" | ||
| request_body = self.__request_body( | ||
| query=query, variables=variables, operation_name=operation_name | ||
| ) | ||
|
|
||
| result = requests.post( | ||
| post_method = requests.post | ||
| if session: |
There was a problem hiding this comment.
We should validate the type that session is a Session to prevent injection.
Suggested change
| if session: | |
| if isinstance(session, Session): |
Co-authored-by: Justin Krinke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Added support in requests.Session in order to solve #54
What is the current behavior?
client.execute() calls to requests.post(), using a session object is not available.
What is the new behavior?
client.execute() gets a new parameter named
sessionthat holds a Session object that will be used for making the POST request.The new parameter is None by default, if its None a new session is created and will be used for making the POST request.
Does this PR introduce a breaking change?
No, you can still skip passing session parameter and the code will act the same as before.
Other information
This feature allows users to:
Don't override
Authorizationheader when contents are bearer token (or any other token) psf/requests#3929