Skip to content

fix(sponsor): reject non-numeric amount types #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aiirvizionz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(sponsor): reject non-numeric amount types #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions apps/web/lib/sponsor-amount.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,19 @@ describe("normalizeSponsorAmountUsd", () => {
error: "Enter a valid sponsorship amount.",
});
});

it("rejects non-string and non-number values before numeric coercion", () => {
expect(normalizeSponsorAmountUsd([5])).toEqual({
ok: false,
error: "Enter a valid sponsorship amount.",
});
expect(normalizeSponsorAmountUsd({ valueOf: () => 5 })).toEqual({
ok: false,
error: "Enter a valid sponsorship amount.",
});
expect(normalizeSponsorAmountUsd(true)).toEqual({
ok: false,
error: "Enter a valid sponsorship amount.",
});
});
});
3 changes: 3 additions & 0 deletions apps/web/lib/sponsor-amount.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ export function normalizeSponsorAmountUsd(
if (typeof value === "string" && !/^\d+(?:\.\d+)?$/.test(value.trim())) {
return { ok: false, error: "Enter a valid sponsorship amount." };
}
if (typeof value !== "string" && typeof value !== "number") {
return { ok: false, error: "Enter a valid sponsorship amount." };
}

const amount = Math.round(Number(value) * 100) / 100;
if (!Number.isFinite(amount)) {
Expand Down
Loading