fix: validate SESSION_SECRET in production to prevent fallback-to-insecure - #95
Open
Inkcha wants to merge 1 commit into
Open
fix: validate SESSION_SECRET in production to prevent fallback-to-insecure#95Inkcha wants to merge 1 commit into
Inkcha wants to merge 1 commit into
Conversation
…ecure The sessionSecret defaulted to a hardcoded dev-only value if SESSION_SECRET env var was not set. In production this means anyone knowing the default can forge session tokens. This change throws a startup error in production if SESSION_SECRET is missing, while preserving the dev fallback for local development. Fixes the HIGH severity issue reported in profullstack#88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents the insecure default \SESSION_SECRET\ from reaching production. If the env var is missing when \NODE_ENV=production, the app now throws at startup instead of silently using a hardcoded dev fallback.
Changes
Related
Fixes the HIGH severity issue reported in #88
Testing