fix: prevent promo code over-redemption race condition - #98
Open
Inkcha wants to merge 2 commits into
Open
Conversation
added 2 commits
July 27, 2026 19:43
getCoinpayPayment() and createPayment() silently swallowed all errors and returned null. This made payment failures invisible — a temporary CoinPay API outage would silently deny users their paid entitlements with no alert. Added console.error logging so operational issues are visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Race condition in promo code redemption: two concurrent requests could both pass the duplicate SELECT check before either INSERT executes, allowing the code to be redeemed N+1 times instead of once.
Fix
Removed the duplicate SELECT check in quotePromo() — the INSERT (composite PK on code+user_id) is atomic and will fail if the redemption already exists. The catch in recordPromoRedemption handles this naturally.
Related
Fixes #92