Skip to content

fix(core): verify gossip source matches claimed peer_id in auction bids/receipts #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jul 12, 2026
Merged

fix(core): verify gossip source matches claimed peer_id in auction bids/receipts #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions node/crates/c0mpute-core/src/buyer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,14 @@ pub async fn run_auction(
if bid.job_id == job_id
&& bid.bidder_peer_id != offer.buyer_peer_id
{
if !source_matches_claim(&msg, &bid.bidder_peer_id) {
warn!(
%job_id,
claimed = %bid.bidder_peer_id,
"buyer: discarding bid, gossip source does not match claimed bidder_peer_id"
);
continue;
}
debug!(
%job_id,
bidder = %bid.bidder_peer_id,
Expand Down Expand Up @@ -185,6 +193,14 @@ pub async fn run_auction(
if receipt.job_id == job_id
&& receipt.worker_peer_id == winner.bidder_peer_id
{
if !source_matches_claim(&msg, &receipt.worker_peer_id) {
warn!(
%job_id,
claimed = %receipt.worker_peer_id,
"buyer: discarding receipt, gossip source does not match claimed worker_peer_id"
);
continue;
}
info!(
%job_id,
status = ?receipt.status,
Expand Down Expand Up @@ -235,6 +251,19 @@ async fn publish_json<T: serde::Serialize>(
net.publish(topic, bytes).await
}

/// Gossipsub gives us a cryptographically-authenticated `source: Option<PeerId>`
/// (see `c0mpute_net::GossipMessage`) that cannot be forged by another peer —
/// `capabilities.rs`'s ad registry already keys off it for the same reason.
/// `JobBid.bidder_peer_id` / `JobReceipt.worker_peer_id` are just self-reported
/// strings inside the signed-later-but-not-yet payload, so without this check
/// any peer can claim to be any other peer_id in a bid or completion receipt.
fn source_matches_claim(msg: &GossipMessage, claimed_peer_id: &str) -> bool {
match &msg.source {
Some(source) => source.to_base58() == claimed_peer_id,
None => false,
}
}

fn unix_ms() -> u64 {
std::time::SystemTime::now()
.duration_since(std::time::UNIX_EPOCH)
Expand Down
Loading