Nightcell were construction workers; count only SFX in the budget - #21
Merged
Conversation
… the budget Swaps the Nightcell model from the pack's `Worker` to `Adventurer`. `Worker` is a hi-vis construction labourer and read exactly like one — my pick, and a bad one for an irregular fighter. `Adventurer` is olive drab with boots and a pack, which reads as someone fighting with what they own. `Casual_Hoodie` was the other candidate and is a teenager in shorts. Also fixes the download budget, which had quietly swallowed 22 MB of music. The exclusion was a `^music_` pattern, so it under-counted the moment a track arrived under its own name — which two did. It now allowlists the generated effects instead: anything else in that directory is user-supplied media, streamed on demand and outside the shell entirely. Shell total is back to 6.20 MB with six tracks streamed separately. New tracks renamed to slugs and registered. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
The two licensed characters are 2.8 MB between them and pushed the set to 6.2 MB legitimately, not through a runaway. The guard was an arbitrary "roughly double current usage"; the real constraint is the 15 MB shell budget, and 9 MB still leaves headroom while catching a genuine mistake such as an uncompressed texture set or a committed master. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the Nightcell model from the pack's
WorkertoAdventurer.Workeris a hi-vis construction labourer and read exactly like one — my pick, and a bad one for an irregular fighter.Adventureris olive drab with boots and a pack. (Casual_Hoodiewas the other candidate and is a teenager in shorts.)Also fixes the download budget, which had quietly swallowed 22 MB of music. The exclusion was a
^music_pattern, so it under-counted the moment a track arrived under its own name — which two did. Now allowlists the generated effects instead: anything else in that directory is user-supplied media, streamed on demand and outside the shell. Shell total back to 6.20 MB, six tracks streamed separately.201 tests pass. Format, lint, typecheck clean.
🤖 Generated with Claude Code