Brighten the yard, add game audio, expand site imagery - #6
Merged
Conversation
Four things, from one round of feedback.
**Brightness.** The yard read as near-black. Raised ambient fill 2.15 -> 4.05,
environment intensity 1.4 -> 2.9, key 4.2 -> 5.4, exposure 1.62 -> 2.05, and
eased the vignette from 2.4 to 1.35 — at that weight the outer third of every
frame fell away to black, which reads as "dark scene" even when the centre is
correctly exposed.
**Audio.** The game shipped completely silent: no clips, no audio code.
tools/art/audio/generate.py synthesises the whole V1 set from first principles
— nothing sampled, nothing licensed — and apps/game/src/audio.ts plays it.
- 22 clips, 0.31 MB as MP3. WAV masters are a build artefact and are not
committed, since they are exactly reproducible (CLAUDE.md).
- Repeated sounds get real variations (CLAUDE.md) and the same variant never
plays twice in a row.
- Footsteps advance with distance travelled, so they track sprinting and
crouching with no state machine, and grating sounds different from
concrete — a real cue that someone is on the catwalk.
- Fire cadence comes from fireIntervalMs() in game-core, the same table the
server enforces, so the sound cannot drift from the actual rate of fire.
Two things that would have been silent failures: an AudioContext created
before a user gesture starts suspended and discards everything played into
it, so unlock() runs on pointer lock; and the fade helper was symmetric,
putting a 3 ms ramp directly on the gunshot transient and costing 20% of the
peak. Fades are now asymmetric.
**Site imagery.** Four new vantages (pipe-rack-run, container-alley,
muster-point, under-the-gantry) and capture plates on downloads,
system-requirements, news, credits, faq and community-guidelines — 11 pages
with imagery, up from 5. Legal, auth and transactional pages are deliberately
left alone; a decorative screenshot on a password reset makes it worse.
**Quality.** Captures are now 2560x1440 at WebP q90, and photo mode renders
with 8x MSAA at native scale. A still is not bound by the frame budget
gameplay is.
Also: gallery frames are clickable, opening a zoomable fullscreen viewer. It
is a real modal — focus moves in, Escape closes, Tab is trapped, focus returns
to the opener — because WCAG 2.2 AA is a launch gate (PRD §22.6) and a div
with an onClick would look identical and be unusable with a keyboard.
Renamed GreyboxNotice -> CaptureNotice and dropped "greybox" from the copy: it
was accurate before the art landed and is not now.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four things from one round of feedback.
Brightness
The yard read as near-black. Ambient fill 2.15 → 4.05, environment 1.4 → 2.9, key 4.2 → 5.4, exposure 1.62 → 2.05, and the vignette eased 2.4 → 1.35 — at that weight the outer third of every frame fell to black, which reads as "dark scene" even when the centre is correctly exposed.
Audio — the game was completely silent
No clips, no audio code.
tools/art/audio/generate.pysynthesises the V1 set from first principles (nothing sampled, nothing licensed);apps/game/src/audio.tsplays it. 22 clips, 0.31 MB.fireIntervalMs()in game-core — the same table the server enforcesTwo would-be silent failures caught: an
AudioContextcreated before a user gesture starts suspended and discards everything played into it, sounlock()runs on pointer lock; and the fade helper was symmetric, putting a 3 ms ramp directly on the gunshot transient and costing 20% of the peak.Site imagery
Four new vantages and capture plates on six more pages — 11 pages with imagery, up from 5. Legal, auth and transactional pages are deliberately left alone; a decorative screenshot on a password reset makes it worse.
Quality
Captures now 2560×1440 at WebP q90 (was 1920×1080 q82), and photo mode renders at 8× MSAA and native scale.
Gallery lightbox
Frames are clickable and open a zoomable fullscreen viewer. It's a real modal — focus moves in, Escape closes, Tab is trapped, focus returns to the opener — because WCAG 2.2 AA is a launch gate (PRD §22.6).
Also renamed
GreyboxNotice→CaptureNoticeand dropped "greybox" from the copy; it was accurate before the art landed and isn't now.190 tests pass (was 188). Format, lint, typecheck clean; site and game both build.
🤖 Generated with Claude Code