Stop the PowerShell install flaking CI - #9
Merged
Conversation
The character was stacked axis-aligned cubes and read as a Minecraft figure. No amount of texturing fixes a silhouette made of blocks. It is now lofted: `_lib.loft`/`limb`/`ring` bridge cross-sections whose radius changes along their length, so the torso has a waist and limbs taper, with hard-surface gear layered on top and subdivision applied only to the body — a smoothed plate carrier looks inflated rather than rigid. The art direction is doing real work. A helmeted, visored operative in heavy gear is almost entirely hard surface, which is what a script is good at; faces, skin and bare hands are what procedural generation cannot do well, and this design shows none of them. That is a deliberate choice rather than a dodge. Gear: helmet with brow, visor, side rails, NVG mount and ear cups; plate carrier with shoulder yoke and cummerbund; magazine pouches, radio, admin pouch; pauldrons; belt, holster, dump pouch; knee pads, gloves, boots; backpack. 6.3k triangles. Two iterations went into proportion. Pauldrons lofted with straight sides and capped ends rendered as blobs floating beside the body, so they now taper at both ends and blend into the arm; the first tapered version was 19x25 cm and swallowed the arms entirely, so they are 13x18 cm. preview.py gains --front. Props are authored facing +Y and the camera was placed to suit them, so a character — which faces -Y — was being reviewed from behind. Also stops tracking __pycache__, which an earlier `git add -A` swept in. Still outstanding and the bigger gap: there is no animation system, so the character does not move. A rig and animation cycles are the next step. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The installer check resolves the PowerShell download URL from the GitHub API unauthenticated, which is rate-limited on shared runners. When the limit was hit the lookup returned an empty string, `curl -fsSL ""` failed, and the job went red on main for a reason unrelated to the code — format, lint, typecheck and test had all passed. Authenticates the lookup with GITHUB_TOKEN, retries it three times, and falls back to a pinned release if the API is unreachable. The download itself also retries. The check stays blocking. It exists because PowerShell runs on Linux, so install.ps1 can be verified rather than trusted on inspection, and making it non-blocking would quietly give that up. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating a Railway build-failed email I found a red X on
mainfrom the PR #5 merge. Format, lint, typecheck and test all passed — the failure was the Install PowerShell step.It resolves the download URL from the GitHub API unauthenticated, which is rate-limited on shared runners. Hitting the limit returned an empty string, so
curl -fsSL ""failed and took the job down with it.Now: authenticated with
GITHUB_TOKEN, three retries on the lookup, a pinned fallback release if the API is unreachable, and retries on the download itself.The check stays blocking — it exists so
install.ps1is verified rather than trusted on inspection (PowerShell runs on Linux), andcontinue-on-errorwould quietly give that up.🤖 Generated with Claude Code