fix(webhooks): block private IPv4-mapped hosts - #162
Merged
ralyodio merged 1 commit intoJul 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::ffff:a9fe:a9feWhy
The webhook destination validator blocked private IPv4 literals and common IPv6 local ranges, but Node normalizes inputs like
http://[::ffff:169.254.169.254]/hookto::ffff:a9fe:a9fe. That bypassed the existing mapped-host string checks and could allow SSRF-style webhook destinations to private infrastructure.Validation
validateWebhookUrland verified mapped169.254,172.16,10, and192.168hosts are blocked while a public mapped address is allowed.git diff --checkNote:
pnpm exec vitest run tests/webhook-url-validation.test.jsattempted a Windows postinstall and failed on the repo's POSIXcommand -v ... || truehook. Running the local Vitest shim then hit a Vite/plugin-react export mismatch under Node 24 before test collection, so I validated the pure URL helper directly with Node and left the Vitest regression in the PR for CI.