fix(auth): trim anonymous registration usernames - #163
Closed
aiirvizionz wants to merge 1 commit into
Closed
Conversation
| return NextResponse.json({ error: 'Invite token is required' }, { status: 400 }); | ||
| } | ||
| if (!username || typeof username !== 'string') { | ||
| if (!cleanUsername) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Anonymous invite registration accepted raw username strings. A value like
alicecould be stored with leading/trailing spaces, and a whitespace-only username could get past the basic truthiness check. That makes account display and duplicate detection less reliable.Validation
node --check src/app/api/auth/register-anon/route.jsnode --check src/app/api/auth/register-anon/route.test.jsgit diff --checkNote:
node_modules/.bin/vitest.cmd run src/app/api/auth/register-anon/route.test.jsstill fails before test collection because this repo's Vitest config loads @vitejs/plugin-react against a Vite build that does not export./internalunder the current Windows/Node runtime. The focused regression test is included for CI once the project runner resolves normally.