fix(tcfeed): stop telling --refresh it changed nothing - #136
Merged
Conversation
The footer is gated on !fix and does not know --refresh exists, so a run that had just pushed a commit to forty-four repositories signed off with Nothing was changed. That is not a cosmetic wording problem. --refresh is the one path that writes to other people's forks without being asked to again, and the line an operator reads at the end of it is the line they will believe. Saying nothing happened after forty-four commits invites re-running it to make something happen. Gated on !fix && !refresh. The read-only pass still prints it, which is where it was always true and is the only place it belongs. Verified both directions: --refresh on an already-current repository prints its result and stops, and a plain check still prints the footer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ThreatCrush Security Scan67 finding(s) HIGH/CRITICAL: 11 | MEDIUM: 55 | LOW: 1
…and 17 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer is gated on
!fixand doesn't know--refreshexists, so a run that had just pushed a commit to 44 repositories signed off with:That isn't a wording nit.
--refreshis the one path that writes to other people's forks without being asked again, and the line an operator reads at the end of it is the line they'll believe. Saying nothing happened after 44 commits invites re-running it to make something happen.Fix
Gated on
!fix && !refresh. The read-only pass still prints it — that's where it was always true and the only place it belongs.Verification
Both directions:
check --refresh <repo>on an already-current repo → prints its result and stops, no footercheck <repo>→ still prints the footerFound while refreshing all 45 open requests onto the hash-verifying pack (#134 / profullstack/sh1pt#959).
🤖 Generated with Claude Code