feat(store): expose a listing's CRX public key to its owner - #46
Merged
Conversation
The store generates and holds the signing key, and returned only the derived extension id. But the public half is what a publisher needs in manifest.json's "key" field — without it an unpacked install gets a per-machine id, so a locally-loaded copy and the store-packed .crx resolve to different extensions. That matters for anything keyed off the id. The immediate case is an OAuth redirect URI (https://<id>.chromiumapp.org/), which coinpayportal validates by exact match, so the id has to be pinned before a client can be registered at all. Public keys are not secret; this returns it from the generate response and on the listing for the owner only. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #45.
The store holds the signing key and returned only the derived extension id. The public half is what a publisher needs in
manifest.json's"key"field — without it, an unpacked install gets a per-machine id, so a locally-loaded copy and the store-packed.crxresolve to different extensions.That blocks anything keyed off the id. The immediate case: an OAuth redirect URI (
https://<id>.chromiumapp.org/), which coinpayportal validates by exact match (src/lib/oauth/client.ts:53), so the id must be pinned before a client can be registered at all.Returned from the generate response, and on the listing for the owner only. Public keys aren't secret, but there's no reason to hand every visitor a listing's signing material.
tscclean, 47/47 store tests.🤖 Generated with Claude Code