feat(store): replace alert/confirm/prompt with <dialog> - #47
Merged
Conversation
Native dialogs render as browser chrome outside the page's styling and block the tab. The worst offender was the signing-key warning: an irreversible, identity-setting decision asked through a grey OS box that looks indistinguishable from a phishing popup. Adds openModal/uiAlert/uiConfirm/uiChoose on <dialog>, and replaces all six call sites. The abuse report was a prompt() asking people to type one of "malware, privacy, broken, spam, other" — it is now a <select> of exactly those, so a typo can't produce an unclassifiable report. The signing-key confirm is styled destructive. Falls back to toggling `open` and firing `close` where the <dialog> methods are unavailable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native dialogs render as browser chrome outside the page's styling and block the tab.
The worst offender was the signing-key warning added in #45: an irreversible, identity-setting decision asked through a grey OS box that looks indistinguishable from a phishing popup.
Adds
openModal/uiAlert/uiConfirm/uiChooseon<dialog>, replacing all six call sites (1prompt, 4alert, 1confirm).One upgrade beyond a like-for-like swap: the abuse report was a
prompt()asking people to type one of "malware, privacy, broken, spam, other". It's now a<select>of exactly those, so a typo can't produce an unclassifiable report. The signing-key confirm is styled destructive.Falls back to toggling
openand firingclosewhere the<dialog>methods are unavailable.node --checkpasses; noalert/confirm/promptremain in the file.🤖 Generated with Claude Code