chore(release): v3.8.4 - #50
Merged
Merged
Conversation
Ships the extension CoinPay sign-in fix (#49): the extension asked the backend to redirect to an off-origin chromiumapp.org callback, safeRedirect() rejected it, and only the website ended up signed in. Bumps every workspace package, the Expo app, and the AI sidebar extension manifest to 3.8.4 via scripts/set-version.mjs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump only — no code changes.
scripts/set-version.mjs 3.8.4across every workspace package, the Expo app, and the AI sidebar extension manifest (25 files, version lines only).What this ships
#49 — the extension CoinPay sign-in fix. The extension asked the backend to redirect back to
chrome.identity.getRedirectURL()(off-originchromiumapp.org);safeRedirect()rejected it and the callback fell through to${APP_URL}/?signedin=1, so the website got the session cookie and the extension got nothing.New
/api/auth/ext-loginadopts an existing website session directly and lands the token on an on-origin/ext-callback.html?src=tb. Also included: thenoUncheckedIndexedAccessbuild fix that had CI red on main since #48.Why it needs a release
install.sh:53resolves "latest" from the GitHub API'sreleases/latest— a published release, not a tag. Until v3.8.4 is published,tronbrowser updatecorrectly reports "already up to date (v3.8.3)" and no user can pull the fix.Verification
pnpm -r build— exit 0pnpm -r test— exit 0, 22 packagesidentitypermission removal from fix(auth): extension CoinPay sign-in never picked up the session #49 is intactAfter merge
Tag to trigger
release.yml:🤖 Generated with Claude Code