Skip to content

fix exports when column eval returns collection of objects #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix exports when column eval returns collection of objects #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Griddly.Mvc/GriddlyColumn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ public override object RenderCellValue(object row, bool stripHtml = false)

if (stripHtml && value is string valueString && !string.IsNullOrEmpty(valueString))
value = HttpUtility.HtmlDecode(_htmlMatch.Replace(valueString, "").Trim().Replace(" ", " "));

if (value is IEnumerable<object> coll)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Not sure if we want Griddly to handle this automatically or if it should just be in the template (Joel and Chris please chime in)

  2. This doesn't handle cases where the generic collection is of a primitive type (int, decimal, Enum, etc). You could check for the non-generic IEnumerable, but watch out for string (which is IEnumerable)

  3. Should the string.Join("," be string.Join(", " (note space after the comma)?

  4. To be consistent, should the same logic apply in RenderCell() and RenderUnderlyingValue()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's it currently render as? [object Object]? I think we probably want to at least make that saner by default.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ithielnor My concern is, if we support Collections as an expression, do we fully support it? Or are there other things that won't work properly (sorting for instance).

Copy link
Collaborator

@jehhynes jehhynes Jul 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Currently sort is already an issue when having non-system objects as the expression. I picked a grid at random in M3 (Memberships/Assessment/AuditsGrid) and it has a .Column(c => c.FeeType) which is a mapped object in NH. Sorting by it sorts by Id instead of by Name (although the name is rendered because that's the behavior of ToString()).

Of course, you can say the solution is to make the column be .Column(c => c.FeeType.Name) OR to set an expressionString. It's not griddly's fault.

But what I'm saying is that by supporting this in Griddly, we're enabling sloppy coding which causes buggy behavior. Case in point above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting is a function of the data access object, not the grid model. RenderCellValue comes after the expression resolution. I'm ok with it. It makes it easier to do things like:

.Column(x => x.Children, expressionString: "ChildrenWarehouse") // render the actual children, but sort by the warehouse

If we want to be overly helpful, we could set expressionString to nothing when the lambda evaluates to a collection too (if we don't already). That would make .Column(x=> collectionpath) just render as a non-sortable column.

Copy link
Collaborator

@jehhynes jehhynes Jul 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, should do the same thing (make it non-sortable) for other unrecognized types. We'd probably need a registry of known sortable types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In M3, this is only a problem for custom query output where the user cannot select a property from the objects in the collection. In this case, it only outputs the first object in the collection.

value = string.Join(",", coll.Select(x => x?.ToString()));
return value;
}
}
Expand Down