Skip to content

feat(RHOAIENG-26590): Report RayJob status via SDK #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chipspeak
Copy link
Contributor

@chipspeak chipspeak commented Jul 29, 2025

Issue link

Jira

What changes have been made

Reporting RayJob status in the SDK using similar logic to RayCluster status reporting.

Verification steps

  1. Follow the same steps as in the previous feature PR
  2. Once the job has been submitted run rayjob.status() to observe the status output.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2025
@chipspeak chipspeak force-pushed the RHOAIENG-26590 branch 2 times, most recently from c5e9964 to f232878 Compare July 30, 2025 09:41
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.06%. Comparing base (bfff951) to head (d1be9e8).
⚠️ Report is 1 commits behind head on ray-jobs-feature.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           ray-jobs-feature     #868      +/-   ##
====================================================
+ Coverage             92.64%   93.06%   +0.41%     
====================================================
  Files                    26       28       +2     
  Lines                  1427     1513      +86     
====================================================
+ Hits                   1322     1408      +86     
  Misses                  105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chipspeak chipspeak force-pushed the RHOAIENG-26590 branch 4 times, most recently from 1e7a12a to 5ecefae Compare July 30, 2025 10:04
@chipspeak chipspeak marked this pull request as ready for review July 30, 2025 10:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2025
@chipspeak chipspeak requested a review from kryanbeane July 30, 2025 10:46
@chipspeak
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2025
@pawelpaszki
Copy link
Contributor

I verified the behaviour. it works as per the verification steps. thanks @chipspeak !

@chipspeak chipspeak force-pushed the RHOAIENG-26590 branch 2 times, most recently from 33368c3 to 17faad7 Compare July 30, 2025 14:09
Copy link
Contributor

@kryanbeane kryanbeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than my one comment re naming conventions, which the more I think about it, could be a one story pointer we do afterwards this is great. thanks Pat 🥇

Copy link
Contributor

@kryanbeane kryanbeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2025
@chipspeak
Copy link
Contributor Author

/cancel

@chipspeak
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2025
@chipspeak
Copy link
Contributor Author

/woof

Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

@chipspeak: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit e2fc98b into project-codeflare:ray-jobs-feature Jul 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants