-
Notifications
You must be signed in to change notification settings - Fork 56
feat(RHOAIENG-26590): Report RayJob status via SDK #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RHOAIENG-26590): Report RayJob status via SDK #868
Conversation
c5e9964
to
f232878
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ray-jobs-feature #868 +/- ##
====================================================
+ Coverage 92.64% 93.06% +0.41%
====================================================
Files 26 28 +2
Lines 1427 1513 +86
====================================================
+ Hits 1322 1408 +86
Misses 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1e7a12a
to
5ecefae
Compare
/hold |
I verified the behaviour. it works as per the verification steps. thanks @chipspeak ! |
33368c3
to
17faad7
Compare
Signed-off-by: Pat O'Connor <[email protected]>
17faad7
to
d1be9e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than my one comment re naming conventions, which the more I think about it, could be a one story pointer we do afterwards this is great. thanks Pat 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kryanbeane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cancel |
/unhold |
/woof |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e2fc98b
into
project-codeflare:ray-jobs-feature
Issue link
Jira
What changes have been made
Reporting RayJob status in the SDK using similar logic to RayCluster status reporting.
Verification steps
rayjob.status()
to observe the status output.Checks