Open
Conversation
armaniferrante
commented
Apr 6, 2021
| @@ -1,5 +1,5 @@ | |||
| language: node_js | |||
| node_js: 10 | |||
| node_js: 14 | |||
Contributor
Author
There was a problem hiding this comment.
Bumping node version fixes FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
armaniferrante
force-pushed
the
armani/wormhole
branch
from
f552431 to
2d77694
Compare
armaniferrante
changed the title
armaniferrante
changed the title
armaniferrante
commented
May 6, 2021
|
|
||
| // Close the open orders account, if needed. | ||
| if (needsCreateOpenOrders) { | ||
| // TODO: enable once the dex supports this. |
Contributor
Author
There was a problem hiding this comment.
Open PR for this against the dex here project-serum/serum-dex#112. Not a blocker but would be nice to have.
Merged
|
This is a wonderful idea, hope it gets added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds convert box for swapping from sollet wrapped tokens -> wormhole wrapped tokens.