Skip to content

[WIP] Explicit flows for wrapping and token initialization#64

Open
armaniferrante wants to merge 4 commits intomasterfrom
armani/wrap
Open

[WIP] Explicit flows for wrapping and token initialization#64
armaniferrante wants to merge 4 commits intomasterfrom
armani/wrap

Conversation

@armaniferrante
Copy link
Contributor

@armaniferrante armaniferrante commented Jun 30, 2021

Addresses #63

Changes:

  • displays wrap/unwrap when swapping between sol/wrapped-sol
  • displays "create accounts" when the "to token" (or quote token for a transitive swap) does not have an account created
  • displays "create accounts" when the DEX open orders accounts aren't created

TODO:

  • display wrap/unwrap when displaying a wormhole or sollet swap market

@armaniferrante armaniferrante changed the title Explicit flows for wrapping and token initialization [WIP] Explicit flows for wrapping and token initialization Jun 30, 2021
@secretshardul
Copy link
Contributor

I'm working to update states after "create accounts" is called, should make a PR tomorrow. It would be better if wrap/unwrap could is implemented through a separate PR, as we want to deploy "create accounts" in production.

@secretshardul
Copy link
Contributor

secretshardul commented Sep 1, 2021

Please approve #77

@secretshardul
Copy link
Contributor

secretshardul commented Sep 27, 2021

How to proceed on the Sollet and Wormhole update? I'm thinking as follows:

@secretshardul
Copy link
Contributor

Sollet unwrap for wUSDC and wUSDT is supported now. Wormhole token swaps shouldn't need code changes. We just list the wormhole markets on Solana's token list so that swaps are enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants