[v4.1.x] Additional fixes for 4.1.6 #927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, breaks builds with newer Boost versions. Also set policy CMP0167 to NEW and forcing CMake to use the Config package and not the built-in module. Will now require Boost 1.70, but this should be available everywhere.
kblaschke
requested review from
blaquewithaq,
dpw13,
mbaetgen-wup and
revmischa
kblaschke
added
important
Also output additional information in both cases (found/not found).
kblaschke
force-pushed
the
v4.1.x-cherry-picked-fixes-for-4.1.6
branch
from
4866888 to
148d180
Compare
Signed-off-by: Kai Blaschke <[email protected]>
kblaschke
force-pushed
the
v4.1.x-cherry-picked-fixes-for-4.1.6
branch
from
148d180 to
e36ad01
Compare
kblaschke
force-pushed
the
v4.1.x-cherry-picked-fixes-for-4.1.6
branch
from
e36ad01 to
0c71b10
Compare
kblaschke
changed the title
kblaschke
force-pushed
the
v4.1.x-cherry-picked-fixes-for-4.1.6
branch
from
0c71b10 to
d957272
Compare
Open
2 tasks
…hader Only custom waves set the point size to 2, default waveforms still render the 2x2 pattern when using dots. Other draw calls aren't affected as they only draw lines/triangles, but it's good practice to not leave the uniform in an undefined state. Signed-off-by: Kai Blaschke <[email protected]>
All waves were rendered upside-down, breaking presets requiring the wave to be at the top or bottom due to warp movement. Using the flipped transformation matrix for drawing will take care of this globally. Also fixed two small mistakes regarding operators. Signed-off-by: Kai Blaschke <[email protected]>
kblaschke
force-pushed
the
v4.1.x-cherry-picked-fixes-for-4.1.6
branch
from
d957272 to
60b60dc
Compare
mbaetgen-wup
approved these changes
Nov 12, 2025
Signed-off-by: Kai Blaschke <[email protected]>
Fixes "martin - mayday (shifters escape retouched).milk" and probably some others. Signed-off-by: Kai Blaschke <[email protected]>
Signed-off-by: Kai Blaschke <[email protected]>
Signed-off-by: Kai Blaschke <[email protected]>
Signed-off-by: Kai Blaschke <[email protected]>
…eadability. Signed-off-by: Kai Blaschke <[email protected]>
Signed-off-by: Kai Blaschke <[email protected]>
kblaschke
force-pushed
the
v4.1.x-cherry-picked-fixes-for-4.1.6
branch
from
60b60dc to
68d9832
Compare
Member
Author
|
Added a bunch more fixes from @yoyofr |
revmischa
approved these changes
Nov 19, 2025
| m_writer.Write("("); | ||
| OutputExpression(argument[0], &functionCall->function->returnType); | ||
| m_writer.Write(")"); | ||
| handled = true; |
Member
Author
There was a problem hiding this comment.
I don't see how. The other branch writes pow(abs(arg1), arg2) while this here just writes (arg1), and there are two different paths which end up with the pow function being written (arg2 not being a literal expression and arg2 not being exactly 1 or 1.0).
If you could provide a more complete example, that might be helpful.
…eral 1 as exponent Signed-off-by: Kai Blaschke <[email protected]>
kblaschke
force-pushed
the
v4.1.x-cherry-picked-fixes-for-4.1.6
branch
from
8ce4ab8 to
b56c3e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked Boost-/build-related fixes and workflow improvements from master. Also bumped the projectm-eval submodule to v1.0.5. The version was already set to 4.1.6 for immediate release after merge.
vertex_point_sizeuniform in untextured draws to the proper value instead of leaving it undefined.