doc: fix doc error in ivshmem mmio registers #8745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACRN IVSHMEM follows QEMU IVSHMEM spec. IVSHMEM supports MSIx interrupt for doorbell mode. The document of ivshmem high level design is out-of-date. This patch update the mmio register definition of doorbell mode support. Tracked-On: projectacrn#5407 Signed-off-by: Jiayuan Yang <[email protected]>
|
start to build |
shiqingg
reviewed
Aug 18, 2025
| - RO | ||
| - Inter-VM Position register is used to identify the VM ID. | ||
| Its value is zero. | ||
| Its value is equal to device ID. |
There was a problem hiding this comment.
Minor comment: to avoid any confusion, we'd better clarify that this is not the device ID in the PCI configuration space.
How about we refine it like below?
Inter-VM Position register is used to identify the device.
Its value is equal to the ID of the VM (to which the device belongs), in the context of ACRN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACRN IVSHMEM follows QEMU IVSHMEM spec. IVSHMEM supports MSIx interrupt for doorbell mode. The document of ivshmem high level design is out-of-date. This patch update the mmio register definition of doorbell mode support.
Tracked-On: #5407