Vagrantfile: Switch to use CentOS Atomic Host#181
Vagrantfile: Switch to use CentOS Atomic Host#181cgwalters wants to merge 2 commits intoprojectatomic:masterfrom
Conversation
Just putting this out there for discussion. I didn't try switching the development box - if we wanted to do that it should be done via a "pet container". Given we already have the `Dockerfile` I think doing a `docker build` of that in the provisioner would work.
|
Thanks @cgwalters! I'll give it a run and see how things go. |
Vagrantfile
Outdated
| config.vm.define "etcd" do |etcd| | ||
| etcd.vm.box = "fedora/24-cloud-base" | ||
| etcd.vm.box = "centos/atomic-host" | ||
| etcd.vm.network "private_network", ip: "192.168.152.101" |
There was a problem hiding this comment.
Keeping the same address caused me a problem. Vagrant decided not to reuse the address and started to assign other seemingly random ones. Took me a bit to realize that. I'd like to increment the address.
|
@ashcrow a couple nits
|
|
Updated for review comments. I didn't add |
|
@cgwalters fair enough. The changes look good to me. @cooktheryan what do you think? |
|
Not clear to me why the IP addresses are changed, but the end-to-end tests under |
|
☔ The latest upstream changes (presumably #187) made this pull request unmergeable. Please resolve the merge conflicts. |
5 participants
Just putting this out there for discussion. I didn't try switching
the development box - if we wanted to do that it should be done via a
"pet container". Given we already have the
DockerfileI think doinga
docker buildof that in the provisioner would work.