This repository was archived by the owner on Apr 8, 2024. It is now read-only.
Add a item in get_param IOCTL for query GVT active - #7
Open
Shao-Feng wants to merge 1 commit into
Open
Conversation
sysopenci
reviewed
May 29, 2020
sysopenci
left a comment
sysopenci
left a comment
There was a problem hiding this comment.
Autobuild started from pull-request-changes on this PR.
FAILURE: CheckBug Bad comments/Bugs
For more information, see: /absp/builders/celadon-autobuild/builds/2128
sysopenci
reviewed
May 29, 2020
sysopenci
left a comment
sysopenci
left a comment
There was a problem hiding this comment.
Autobuild started from pull-request-changes on this PR.
FAILURE: CheckBug Bad comments/Bugs
For more information, see: /absp/builders/celadon-autobuild/builds/2133
YuanjunHuang
reviewed
Jun 4, 2020
| break; | ||
| case I915_PARAM_IS_GVT: | ||
| value = intel_vgpu_active(i915); | ||
| DRM_INFO("=============Invoking GetParam GVT active, return: %d", intel_vgpu_active(i915)); |
There was a problem hiding this comment.
Is this log really needed or just for debug purpose?
Author
There was a problem hiding this comment.
Just for debugging, I will update it soon
sysopenci
reviewed
Jun 4, 2020
sysopenci
left a comment
sysopenci
left a comment
There was a problem hiding this comment.
Autobuild started from pull-request-changes on this PR.
FAILURE: CheckBug Bad comments/Bugs
For more information, see: /absp/builders/celadon-autobuild/builds/2174
When GVT in kernel is active, return true. that is: GVT-g --- true GVT-d --- false native --- false Tracked-On: OAM-90744 Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
sysopenci
reviewed
Jun 4, 2020
sysopenci
left a comment
sysopenci
left a comment
There was a problem hiding this comment.
Autobuild started from pull-request-changes on this PR.
Cactus automatically verified this PR.
For more information, see: /absp/builders/celadon-autobuild/builds/2183
muhammadaksar
pushed a commit
to muhammadaksar/linux-intel-lts2019-yocto
that referenced
this pull request
Jun 25, 2020
[ Upstream commit 20a785aa52c82246055a089e55df9dac47d67da1 ] This BUG halt was reported a while back, but the patch somehow got missed: PID: 2879 TASK: c16adaa0 CPU: 1 COMMAND: "sctpn" #0 [f418dd28] crash_kexec at c04a7d8c projectceladon#1 [f418dd7c] oops_end at c0863e02 projectceladon#2 [f418dd90] do_invalid_op at c040aaca projectceladon#3 [f418de28] error_code (via invalid_op) at c08631a5 EAX: f34baac0 EBX: 00000090 ECX: f418deb0 EDX: f5542950 EBP: 00000000 DS: 007b ESI: f34ba800 ES: 007b EDI: f418dea0 GS: 00e0 CS: 0060 EIP: c046fa5e ERR: ffffffff EFLAGS: 00010286 projectceladon#4 [f418de5c] add_timer at c046fa5e projectceladon#5 [f418de68] sctp_do_sm at f8db8c77 [sctp] projectceladon#6 [f418df30] sctp_primitive_SHUTDOWN at f8dcc1b5 [sctp] projectceladon#7 [f418df48] inet_shutdown at c080baf9 projectceladon#8 [f418df5c] sys_shutdown at c079eedf projectceladon#9 [f418df70] sys_socketcall at c079fe88 EAX: ffffffda EBX: 0000000d ECX: bfceea90 EDX: 0937af98 DS: 007b ESI: 0000000c ES: 007b EDI: b7150ae4 SS: 007b ESP: bfceea7c EBP: bfceeaa8 GS: 0033 CS: 0073 EIP: b775c424 ERR: 00000066 EFLAGS: 00000282 It appears that the side effect that starts the shutdown timer was processed multiple times, which can happen as multiple paths can trigger it. This of course leads to the BUG halt in add_timer getting called. Fix seems pretty straightforward, just check before the timer is added if its already been started. If it has mod the timer instead to min(current expiration, new expiration) Its been tested but not confirmed to fix the problem, as the issue has only occured in production environments where test kernels are enjoined from being installed. It appears to be a sane fix to me though. Also, recentely, Jere found a reproducer posted on list to confirm that this resolves the issues Signed-off-by: Neil Horman <nhorman@tuxdriver.com> CC: Vlad Yasevich <vyasevich@gmail.com> CC: "David S. Miller" <davem@davemloft.net> CC: jere.leppanen@nokia.com CC: marcelo.leitner@gmail.com CC: netdev@vger.kernel.org Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GVT is active, return true.
Tracked-On: None
Signed-off-by: Shaofeng Tang shaofeng.tang@intel.com