Skip to content

Update args for running gateway api conformance #7300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunjayBhatia wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −19
Open

Update args for running gateway api conformance #7300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions test/conformance/gatewayapi/gateway_conformance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,23 +75,6 @@ func TestGatewayConformance(t *testing.T) {
// Keep the list of skipped features in sync with
// test/scripts/run-gateway-conformance.sh.
SkipTests: []string{
// Checks for the original request port in the returned Location
// header which Envoy is stripping.
// See: https://github.com/envoyproxy/envoy/issues/17318
tests.HTTPRouteRedirectPortAndScheme.ShortName,

// Contour supports the positive-case functionality,
// but there are some negative cases that aren't fully
// implemented plus complications with the test setup itself.
// See: https://github.com/projectcontour/contour/issues/5922
tests.GatewayStaticAddresses.ShortName,

// Skip this test as it uses a Gateway with a name that is too long,
// adding the name in a label value prevents resources to be
// created.
// See: https://github.com/kubernetes-sigs/gateway-api/issues/2592
tests.HTTPRouteInvalidParentRefSectionNameNotMatchingPort.ShortName,

// This test currently fails since we do not program any filter chain
// for a Gateway Listener that has no attached routes. The test
// includes a TLS Listener with no hostname specified and the test
Expand All @@ -106,6 +89,23 @@ func TestGatewayConformance(t *testing.T) {
// TODO: implement percentage based mirroring
// See: https://github.com/projectcontour/contour/issues/7021
features.SupportHTTPRouteRequestPercentageMirror,

// Contour supports the positive-case functionality,
// but there are some negative cases that aren't fully
// implemented plus complications with the test setup itself.
// See: https://github.com/projectcontour/contour/issues/5922
features.SupportGatewayStaticAddresses,

// Checks for the original request port in the returned Location
// header which Envoy is stripping.
// See: https://github.com/envoyproxy/envoy/issues/17318
features.SupportHTTPRoutePortRedirect,

// Skip this test as it uses a Gateway with a name that is too long,
// adding the name in a label value prevents resources to be
// created.
// See: https://github.com/kubernetes-sigs/gateway-api/issues/2592
features.SupportHTTPRouteParentRefPort,
),
}
if os.Getenv("GENERATE_GATEWAY_CONFORMANCE_REPORT") == "true" {
Expand Down
4 changes: 2 additions & 2 deletions test/scripts/run-gateway-conformance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ else
# Keep the list of skipped features in sync with
# test/conformance/gatewayapi/gateway_conformance_test.go.
go test -timeout=40m ./conformance -run TestConformance -gateway-class=contour -all-features \
-exempt-features=Mesh \
-skip-tests=HTTPRouteRedirectPortAndScheme,GatewayStaticAddresses
-exempt-features=Mesh,UDPRoute,HTTPRouteRequestPercentageMirror,GatewayStaticAddresses,HTTPRoutePortRedirect,HTTPRouteParentRefPort \
-skip-tests=HTTPRouteHTTPSListener
fi