Skip to content

Include MORE simulation results for Earth model - #76

Open
lena-noack wants to merge 4 commits into
projectcuisines:mainfrom
lena-noack:main
Open

Include MORE simulation results for Earth model#76
lena-noack wants to merge 4 commits into
projectcuisines:mainfrom
lena-noack:main

Conversation

@lena-noack

Copy link
Copy Markdown

No description provided.

@lena-noack
lena-noack requested review from a team and nichollsh as code owners May 6, 2026 15:45
Add example simulations for TRAPPIST-1b and -1e; depends on hydrogen loss fudge factor, may need to be adjusted to be comparable to models actually simulating hydrogen losses
@lena-noack

Copy link
Copy Markdown
Author

Commit of first TRAPPIST-1 example models; also pull request of Earth models was not yet added several months ago?

@nichollsh nichollsh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Lena, thank you for submitting these data! It's great to have more models to compare with. I am happy to give a first pass at reviewing this PR but would also feel more comfortable if one of the @projectcuisines/chili_admin could also take a look at a later stage.

However, there are a number of issues that need to be addressed here. I am confused about what the model is doing. Some of the data values seem incorrect but it's hard for me to know what to expect from MORE. Perhaps you can clarify these points below?

@lena-noack @philippbaumeister @timlichtenberg

(1) Static vs evolutionary

It was my understanding that MORE is a static model, not an evolutionary model, since it has no notion of time evolution. You mention this in the notes too. If this is the case, why are the data submitted in the format of the evolution codes, rather than in the protocol-defined format for static models? That is: the protocol says that static models should calculate the state at specific times derived from the evolution models (via the Exoplanet paper simulations).

Could you explain why the data are formatted in the evolution-model format rather than the static-model format?

You can see how to do this here: https://github.com/projectcuisines/chili/blob/main/intercomparison/README.md#static-models

(2) Missing values

  • The output CSV files are missing a lot of values and some of the values do not make sense to me. For example, the T_surf(K) doesn't change between the rows, even though the melt fraction is changing. Seems physically inconsistent?

  • If this is being interpreted as an evolution calculation, why does the melt fraction increase down the rows?

  • The fO2_solid(bar) and fO2_melt(bar) values are all constant and seem to be in the wrong units. They are fixed at a value of 4 (I guess meaning IW+4) but the protocol says that these should be absolute $fO_2$ in units of bar.

  • The Venus outputs and several of the exoplanet cases are missing.

  • The file names are mis-formatted. For example, there is a file called ‎evolution-more-evolution-more-trappist1e-data-data.csv which I think should be called evolution-more-trappist1e-data.csv. Although, again, this is related to my point above about static/evolutionary.

(3) Missing profiles?

The CHILI protocol specifies that static models are to ideally provide atmosphere profiles (see here). I do not see these in your output data. If your model doesn't calculate these, then that's fine, but the output format should still follow the static-model specification.

(4) Model description

The model description the -notes.txt file is quite short. The other CHILI models usually provide a citation in this case, or point to their online documentation: e.g. LINCS has some references and MOAI has a website.

Could you perhaps expand your notes file and/or add some references so it's clearer to understand what the model is doing? Maybe this will clarify my points of confusion above.

@lena-noack

lena-noack commented Jun 16, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants