Add static moachi runs config & data - #96
Conversation
add the folder for moachi in outputs
Added a link to input data grid and contact information.
Added notes on MOAChi inputs and procedures.
timlichtenberg
left a comment
There was a problem hiding this comment.
Thanks Bo, this is a strong submission. The full 29-case grid is there, the folder comes to 2.9 MB with the largest single file at 130 kB so both size limits are comfortable, and the surface pressure reproduces the boundary-condition grid input exactly in every case, which was the check I most wanted to see pass. Since MOAChi solves the structure self-consistently, the surface temperature coming out different from the evolution-model snapshot is expected, and it is one of the more interesting things in the submission rather than a problem.
Four things before I merge.
1. The header line starts with # . The first column header reads # z(m) where the format specifies z(m). Any plain CSV reader will produce a column literally named # z(m), which will not match the other models' files. Please drop the # from all 29 files.
2. The rows run top-down. The format has z starting from 0 at the surface, and every other submission is ordered surface-upward, but here the first data row of static-moachi-earth-tau3-cold-data.csv is at z = 631 km and the last is z = 0. Please reverse the row order.
3. Two empty README files. intercomparison/inputs/moachi/README.md and intercomparison/outputs/moachi/README.md are both empty. Either fill them in or drop them.
4. A question rather than a change. The two cold TRAPPIST-1 alpha cases come out hotter than any of the hot cases: tau3-cold reaches 6563 K at the surface and tau4-cold 5252 K, against 3154 K and 3151 K for the corresponding hot runs. I can see where it comes from, since those two have T_eq near 1780 K together with high T_int and surface pressures of 223 bar and 33 bar, but 6563 K is well above the range where a C-H-O-only network is meaningful for a silicate planet, and hot/cold labels that end up inverted will confuse anyone reading the comparison later. Could you check those two, and if the numbers stand, add a sentence to the notes explaining why the cold end-member ends up hotter?
Two smaller points. The notes file says the MOAChi version will be public by Q3 2026 and gives your contact, which meets the minimum the README asks for, but if there is a branch or commit you can name now that would be better for reproducibility. And the note about which runs use bulk elemental abundances versus surface partial pressures is genuinely useful; it would be worth listing which specific runs fell into the "incompatible with the chemical network" category, since that is not recoverable from the files themselves.
…comments, deleted readmes.
|
Hi Tim, I've responded to your requests in the last commit. Please take a look and let me know if everything is ok now. I get the comment on reproducability, in the coming week I'll add the MOAChi branch name to the notes. Just haven't found time to do it properly yet. |
add the folder for moachi in outputs