Make Timeout configurable via a flag#89
Conversation
Signed-off-by: alban.hurtaud <alban.hurtaud@amadeus.com>
|
I'm not sure about this, does having data with multiple different scrape
intervals on a single target make sense for either collectd or Prometheus?
…On Fri 22 Nov 2019, 17:40 Alban Hurtaud, ***@***.***> wrote:
This PR enables the possibility to override the collectd settings Timeout.
It will close #88
<#88>
------------------------------
You can view, comment on, or merge this pull request online at:
#89
Commit Summary
- Make Timeout configurable via a flag
File Changes
- *M* main.go
<https://github.com/prometheus/collectd_exporter/pull/89/files#diff-0>
(14)
Patch Links:
- https://github.com/prometheus/collectd_exporter/pull/89.patch
- https://github.com/prometheus/collectd_exporter/pull/89.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#89?email_source=notifications&email_token=ABWJG5ULBW7RKBCLM7XCEULQVADRJA5CNFSM4JQTG34KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3N6UBQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWJG5TI2PIBMA5EZEDZYKDQVADRJANCNFSM4JQTG34A>
.
|
I think it is technically feasible. |
|
Scrape intervals above 2m are not recommended. What exactly is this data? It sounds like it may be a case for the textfile collector. |
The metrics are MapR Volumes metrics. It works for every metrics except the metrics for volumes (because from what MapR told us, they are "heavy to compute").
And we cannot configure collectd on MapR nodes... This is why we would need such features. |
This PR enables the possibility to override the collectd settings Timeout.
It will close #88