Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlp: Move otlptranslator package from prom/prom to here #755

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented Jan 31, 2025

For eventual import by otel collector

@ArthurSens
Copy link
Member

Nice, thanks for starting this!

I believe we agreed on just moving the "name translator" and not the remotewrite translator. I can't remember exactly why we came to this agreement though 🤔

@ywwg
Copy link
Member Author

ywwg commented Feb 4, 2025

If that was an agreement between you and me, I think that was based on a misunderstanding I had about the code arrangement. Based on the diffing I've done, the translators are pretty close together between prom and otel-col. I think what I'll do is try to work ahead a few PRs and confirm that otel will work when linked against this code. If not then we can avoid rolling things back

For eventual import by otel collector

Signed-off-by: Owen Williams <[email protected]>
@ywwg ywwg force-pushed the owilliams/otlptranslator branch from 9b3b779 to c4158b1 Compare February 4, 2025 20:51
@ArthurSens
Copy link
Member

If that was an agreement between you and me

No, it was within the otel-prom SIG call. It was probably captured in this meeting note's entry, but, if after digging deeper into the code it might sound too difficult, we can re-think that decision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants