Conversation
Add horizontal severity filter tabs (All, Critical, High, Medium, Low) to the advisory feed page. Advisories are filtered by CVSS score ranges matching NVD conventions. Tab counts update dynamically. Co-Authored-By: Claude Opus 4.6 <[email protected]>
3003f04 to
d704eb8
Compare
Replace five duplicated button blocks with a SEVERITY_TABS metadata array and a single .map() loop. Class strings are kept as full literals for Tailwind purge compatibility. Co-Authored-By: Claude Opus 4.6 <[email protected]>
filteredAdvisories is derived from advisories + selectedSeverity and should not be independent state. Replace useState + filtering useEffect with a single useMemo. Keep a minimal useEffect that only resets currentPage on dependency changes. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Add a second row of filter tabs for platform selection using the clawd color palette. Add platforms field to Advisory type to match feed data. Both severity and platform filters compose via useMemo. Co-Authored-By: Claude Opus 4.6 <[email protected]>
…as universal Extract a reusable FilterTabs component so severity and platform tab rows share identical markup. Fix platform filter to treat advisories with missing or empty platforms as matching all platforms, preventing legacy entries from being silently dropped. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
Add severity-based filter tabs (All, Critical, High, Medium, Low) to the FeedSetup advisory feed page, allowing users to quickly filter advisories by severity level. The filtering composes naturally with existing pagination controls.
Changes Made
Related Issues
Type of Change
Testing
Changes implement severity filtering tabs on the FeedSetup advisory feed page following the established filtering pattern from the SkillsCatalog page. The implementation composes with existing pagination controls (ITEMS_PER_PAGE=9).
Checklist
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Enhances the advisory feed page by introducing severity and platform-based filtering tabs that integrate with existing pagination. Updates the
Advisorydata model to support platform categorization and improves the user interface for empty filter states.FilterTabscomponent and filtering logic usinguseMemoto allow users to sort advisories by severity levels and platform types.Modified files (1)
Latest Contributors(2)
Advisoryinterface to include an optionalplatformsarray, enabling the new filtering functionality.Modified files (1)
Latest Contributors(2)