Use ANSI colors for the default theme. #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanslenders
force-pushed
the
ansi-colors-for-default-theme
branch
from
e36c4c5 to
1c77626
Compare
jonathanslenders
force-pushed
the
ansi-colors-for-default-theme
branch
from
1c77626 to
bd118e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many users, code that was printed red was difficult to read, depending on the background color.
The reason is that our themes, which are coming from Pygments all use RGB colors instead of ANSI colors, and we render using 256 colors by default.
This patch adopts the default Pygments theme, but using the closest ANSI color as the default theme, so that we take the ANSI colors that are configured in the terminal, which should normally provide sufficient contrast with the background.