Skip to content
This repository has been archived by the owner on May 30, 2019. It is now read-only.

cleaning up stylesheet, reducing no-descending-specificity errors #411

Closed
wants to merge 1 commit into from
Closed

cleaning up stylesheet, reducing no-descending-specificity errors #411

wants to merge 1 commit into from

Conversation

yungbeto
Copy link
Contributor

No description provided.

@@ -19,7 +19,7 @@
// server-side so the results can be displayed even if javascript is disabled.

// tslint:disable:no-reference
/// <reference path="../node_modules/@types/codemirror/index.d.ts" />
/// <reference path="../node_modules/@type/codemirror/index.d.ts" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be changed

Copy link
Contributor

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - except for the small lint error. I'm a bit concerned this adds lines to main.scss instead of removing lines tho.

h("a", { "href": "/docs" }, "Documentation"),
h("a", { "href": "https://github.com/propelml/propel" }, "GitHub"),
h("a", { "href": "mailto:[email protected]" }, "Contact"),
h("div", { "class": "footer-links" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comma after }

@ry
Copy link
Contributor

ry commented Mar 22, 2018

Discussed offline - closing this PR in favor of one that addresses #416

@ry ry closed this Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants