Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine selection of atoms in REST region using simple heuristic #1524

Merged
merged 23 commits into from
Mar 20, 2025

Conversation

mcwitt
Copy link
Collaborator

@mcwitt mcwitt commented Mar 17, 2025

The initial implementation of REST in single topology transformations in #1424 applies temperature scaling to all ligand-environment nonbonded interactions, and all ligand-ligand proper torsions that are rotatable or in aliphatic rings. I.e., the "REST region" (here, the set of ligand atoms whose interactions may potentially be scaled), is implicitly all of the combined ligand atoms.

This PR refines the REST region using a simple heuristic: a combined ligand atom in included iff it is involved in a bond, angle, or improper torsion interaction whose parameters differ between the end states of the transformation. The logic for scaling the relevant interactions is retained from the previous version, except that we now exclude interactions from scaling that do not involve an atom in the REST region.

This is intentionally a very minimal heuristic. Later on, we might extend this for example to include in the REST region ligand atoms that are not directly mutated in the transformation, but are nearby (e.g. by graph distance) to a mutation.

This PR also adds a utility to visualize the REST region using py3Dmol (similar to the existing view_atom_mapping_3d). Example from the hif2a public benchmark:

TODO:

@mcwitt
Copy link
Collaborator Author

mcwitt commented Mar 17, 2025

Closing temporarily. The REST region inference needs more thought; the current approach incorrectly includes all ligand atoms in the REST region if there is a mutation of any ligand atom due to the ligand-ligand pair interaction parameters changing.

@mcwitt mcwitt closed this Mar 17, 2025
@mcwitt mcwitt reopened this Mar 18, 2025
@mcwitt
Copy link
Collaborator Author

mcwitt commented Mar 18, 2025

Closing temporarily. The REST region inference needs more thought; the current approach incorrectly includes all ligand atoms in the REST region if there is a mutation of any ligand atom due to the ligand-ligand pair interaction parameters changing.

Addressed this by moving to a heuristic only considering differences in bond, angle, and improper torsion valence parameters (dummy atoms are always included in the REST region). This heuristic seems to produce reasonable-looking REST regions in a few examples, but needs further validation.

@mcwitt mcwitt marked this pull request as ready for review March 20, 2025 16:05
@mcwitt mcwitt requested review from proteneer and maxentile March 20, 2025 16:05
params_eq was previously needed to deal with potentials having a single
scalar parameter per interaction
Copy link
Owner

@proteneer proteneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@mcwitt mcwitt merged commit 5124837 into master Mar 20, 2025
1 check passed
@mcwitt mcwitt deleted the rest-heuristic branch March 20, 2025 20:44
@mcwitt mcwitt mentioned this pull request Mar 21, 2025
mcwitt added a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants