-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine selection of atoms in REST region using simple heuristic #1524
Conversation
Cherry-picked from #1523
Defined as combined ligand atoms involved in interactions with parameters that differ at the end states
Closing temporarily. The REST region inference needs more thought; the current approach incorrectly includes all ligand atoms in the REST region if there is a mutation of any ligand atom due to the ligand-ligand pair interaction parameters changing. |
Addressed this by moving to a heuristic only considering differences in bond, angle, and improper torsion valence parameters (dummy atoms are always included in the REST region). This heuristic seems to produce reasonable-looking REST regions in a few examples, but needs further validation. |
Makes invalid values unrepresentable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
The initial implementation of REST in single topology transformations in #1424 applies temperature scaling to all ligand-environment nonbonded interactions, and all ligand-ligand proper torsions that are rotatable or in aliphatic rings. I.e., the "REST region" (here, the set of ligand atoms whose interactions may potentially be scaled), is implicitly all of the combined ligand atoms.
This PR refines the REST region using a simple heuristic: a combined ligand atom in included iff it is involved in a bond, angle, or improper torsion interaction whose parameters differ between the end states of the transformation. The logic for scaling the relevant interactions is retained from the previous version, except that we now exclude interactions from scaling that do not involve an atom in the REST region.
This is intentionally a very minimal heuristic. Later on, we might extend this for example to include in the REST region ligand atoms that are not directly mutated in the transformation, but are nearby (e.g. by graph distance) to a mutation.
This PR also adds a utility to visualize the REST region using

py3Dmol
(similar to the existingview_atom_mapping_3d
). Example from the hif2a public benchmark:TODO: