What: Allow proto definition providers to specify the root of the pro…#30
Open
noel-yap wants to merge 5 commits intoprotop-io:developmentfrom
Open
What: Allow proto definition providers to specify the root of the pro…#30noel-yap wants to merge 5 commits intoprotop-io:developmentfrom
noel-yap wants to merge 5 commits intoprotop-io:developmentfrom
Conversation
Contributor
jefferyshivers
left a comment
There was a problem hiding this comment.
Thank you for opening this - apologies for the delay, but this is on my list to review and test over the weekend
Author
|
Thanks for letting me know. I was starting to get worried. |
…to directory hierarchy. Why: To allow greater flexibility in source code organization.
b25648c to
5f4d2e8
Compare
90a68ba to
a90bbfd
Compare
4ee189b to
c2ebc98
Compare
…feature/allow-root-specification
Author
|
@jefferyshivers , I'm trying to merge but the CI is failing with: and I'm not able to reproduce the problem locally. Any ideas what may be causing this? I'm wondering if it's because of: in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to directory hierarchy.
Why: To allow greater flexibility in source code organization.