Ledger/Registry/Asset Endpoints#642
Draft
jforseth-figure wants to merge 6 commits into
Draft
Conversation
jdfigure
reviewed
Aug 25, 2025
| fun saveLedger(txInfo: TxData, tx: ServiceOuterClass.GetTxResponse, txUpdate: TxUpdate) { | ||
| for (message in tx.tx.body.messagesList) { | ||
| logger.info("Message type: ${message.typeUrl}") | ||
| if (!message.typeUrl.contains("ledger")) { |
Contributor
There was a problem hiding this comment.
Do a starts with match on the "provenance.ledger"
| } | ||
| } | ||
| for (event in tx.txResponse.eventsList) { | ||
| if (!event.type.contains("ledger")) { continue } |
Contributor
There was a problem hiding this comment.
same - do a startsWith provenance.ledger
| if (!event.type.contains("ledger")) { continue } | ||
| logger.info("Event type: ${event.type}") | ||
| when (event.type) { | ||
| "provenance.ledger.v1.EventLedgerCreated" -> { |
Contributor
There was a problem hiding this comment.
there could be a ton of these event types - do we need to know each of them individually? i think the events table has a column for the type so it may not be necessary to parse them out individually
This reverts commit 8ef81b9. Chain message parsing appears to already handle this. No additional `save____()` functions are needed.
Contributor
Author
|
Currently doesn't work because it can't decode the "provenance.registry.v1.MsgGrantRole" messages. Once 1.26 is released and we have the protos, it should work? |
jforseth-figure
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is meant to provide endpoints for more detailed asset information in Pulse.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes