Add ignore flag to exclude markers from value calculations#659
Merged
Conversation
Add ignore_in_value_calculations column to marker_cache to prevent invalid NAVs from affecting chain value metrics. Filter ignored denoms and scopes in all value calculation services.
dcshock
reviewed
Mar 10, 2026
| @@ -0,0 +1,8 @@ | |||
| SELECT 'Add ignore_in_value_calculations column to marker_cache' AS comment; | |||
Contributor
There was a problem hiding this comment.
this is a vibe way of commenting.. interesting.
dcshock
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ignore_in_value_calculations column to marker_cache to prevent invalid NAVs from affecting chain value metrics. Filter ignored denoms and scopes in all value calculation services.