fix protoc missing and insecure docker login#67
Merged
Conversation
rpatel-figure
approved these changes
Jan 8, 2026
| push: true | ||
| tags: | | ||
| ${{ steps.image.outputs.id }}:${{ env.VERSION }} | ||
| ${{ github.event.release.prerelease == false && format('{0}:latest', steps.image.outputs.id) || '' }} |
Collaborator
There was a problem hiding this comment.
I think this syntax for the comparison works but guess we'll see
Collaborator
Author
There was a problem hiding this comment.
anything you're concerned about specifically?
Collaborator
There was a problem hiding this comment.
Just if the comparison works as booleans. With how funky GHA syntax is sometimes, I think a lot of people just default to stringifying any GitHub context variables and always doing comparisons like this as string-to-string.
Collaborator
Author
There was a problem hiding this comment.
Ah, I think it's fine since the release schema specifies
{
"prerelease": {
"description": "Whether to identify the release as a prerelease or a full release.",
"type": "boolean",
"examples": [
false
]
},
}
Thanks for pointing it out. I'm always wary of GitHub expression syntax and I'm never 100% confident
rgipson-figure
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #61
Also fixes protoc issues in release action. Example failure
Changes